Removing all rollup/ contents except join-split as example#124
Merged
dbanks12 merged 13 commits intodefi-bridge-projectfrom Feb 7, 2023
Merged
Removing all rollup/ contents except join-split as example#124dbanks12 merged 13 commits intodefi-bridge-projectfrom
rollup/ contents except join-split as example#124dbanks12 merged 13 commits intodefi-bridge-projectfrom
Conversation
added 6 commits
February 3, 2023 00:02
…except join split
…) for CI. fix bb-tests
suyash67
reviewed
Feb 7, 2023
| #include <ecc/curves/grumpkin/grumpkin.hpp> | ||
|
|
||
| namespace rollup { | ||
| namespace join_split_example { |
There was a problem hiding this comment.
I think the circuit constants for circuits other than join-split can be removed.
added 3 commits
February 7, 2023 14:26
suyash67
approved these changes
Feb 7, 2023
dbanks12
referenced
this pull request
Feb 7, 2023
…llup/ removal, kesha's bigfield fix) (#123) * Target skylake but without avx. * Fix indent. * Fixing fuzzer build (#14) * Add cmake logic to support building of dependent C++/WASM projects (#54) * cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake * Removed all files in rollup/ not necessary for join split tests * dockerfile, script, and ci changes now that rollup contents are gone except join split * remove more unused code from rollup/js dir * removed standard example * rename rollup directory to join_split_example * bigfield fix * filter out longer join split tests (leave only one full proof test in) for CI. fix bb-tests * fix dockerfile now that rollup executables were removed * rename rollup namespace to join_split_example * add blake 3 to executables/libraries in aztec cmakelists * Removing non-join-split constants as per recommendation here https://github.com/AztecProtocol/barretenberg/pull/124\#discussion_r1098698470 * remove vk constants from join-split --------- Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Adam Domurad <adam.domurad@gmail.com> Co-authored-by: ludamad <adam@aztecprotocol.com>
ludamad
referenced
this pull request
in AztecProtocol/aztec-packages
Jul 14, 2023
…llup/ removal, kesha's bigfield fix) (#123) * Target skylake but without avx. * Fix indent. * Fixing fuzzer build (#14) * Add cmake logic to support building of dependent C++/WASM projects (#54) * cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake * Removed all files in rollup/ not necessary for join split tests * dockerfile, script, and ci changes now that rollup contents are gone except join split * remove more unused code from rollup/js dir * removed standard example * rename rollup directory to join_split_example * bigfield fix * filter out longer join split tests (leave only one full proof test in) for CI. fix bb-tests * fix dockerfile now that rollup executables were removed * rename rollup namespace to join_split_example * add blake 3 to executables/libraries in aztec cmakelists * Removing non-join-split constants as per recommendation here https://github.com/AztecProtocol/barretenberg/pull/124\#discussion_r1098698470 * remove vk constants from join-split --------- Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Adam Domurad <adam.domurad@gmail.com> Co-authored-by: ludamad <adam@aztecprotocol.com>
ludamad
referenced
this pull request
in AztecProtocol/aztec-packages
Jul 22, 2023
…llup/ removal, kesha's bigfield fix) (AztecProtocol/barretenberg#123) * Target skylake but without avx. * Fix indent. * Fixing fuzzer build (AztecProtocol/barretenberg#14) * Add cmake logic to support building of dependent C++/WASM projects (AztecProtocol/barretenberg#54) * cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake * Removed all files in rollup/ not necessary for join split tests * dockerfile, script, and ci changes now that rollup contents are gone except join split * remove more unused code from rollup/js dir * removed standard example * rename rollup directory to join_split_example * bigfield fix * filter out longer join split tests (leave only one full proof test in) for CI. fix bb-tests * fix dockerfile now that rollup executables were removed * rename rollup namespace to join_split_example * add blake 3 to executables/libraries in aztec cmakelists * Removing non-join-split constants as per recommendation here https://github.com/AztecProtocol/barretenberg/pull/124\#discussion_r1098698470 * remove vk constants from join-split --------- Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Adam Domurad <adam.domurad@gmail.com> Co-authored-by: ludamad <adam@aztecprotocol.com>
ludamad
referenced
this pull request
in AztecProtocol/aztec-packages
Jul 24, 2023
…llup/ removal, kesha's bigfield fix) (AztecProtocol/barretenberg#123) * Target skylake but without avx. * Fix indent. * Fixing fuzzer build (AztecProtocol/barretenberg#14) * Add cmake logic to support building of dependent C++/WASM projects (AztecProtocol/barretenberg#54) * cmake updates to support dependent projects (native + wasm) * nothing should depend on constants from `rollup/` * use `cmake --build <dir> --parallel` everywhere instead of -j with nprocs * forward all bootstrap args to cmake with --target prefix for each. Use cleaner subshell instead of cd'ing back up after ignition in bootstrap. * allow dependent project to set WASI_SDK_PREFIX and have it be used in wasm-linux-clang.cmake * update readme to use cmake * Removed all files in rollup/ not necessary for join split tests * dockerfile, script, and ci changes now that rollup contents are gone except join split * remove more unused code from rollup/js dir * removed standard example * rename rollup directory to join_split_example * bigfield fix * filter out longer join split tests (leave only one full proof test in) for CI. fix bb-tests * fix dockerfile now that rollup executables were removed * rename rollup namespace to join_split_example * add blake 3 to executables/libraries in aztec cmakelists * Removing non-join-split constants as per recommendation here https://github.com/AztecProtocol/barretenberg/pull/124\#discussion_r1098698470 * remove vk constants from join-split --------- Co-authored-by: Charlie Lye <karl.lye@gmail.com> Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com> Co-authored-by: Adam Domurad <adam.domurad@gmail.com> Co-authored-by: ludamad <adam@aztecprotocol.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing all
rollup/contents except join-split as exampleChecklist:
/markdown/specshave been updated.@briefdescribing the intended functionality.